Repair seams in generated scrolling game backgrounds - #5684
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Generated scrolling backgrounds can fail seamless-edge validation. Adds an opt-in repair mode to SeamlessImage that blends the outer 10% along each requested axis before checking edges, preserves dimensions and center pixels, and handles transparency using premultiplied colors. Repaired output drops the original asset identity. Generated game graphs enable repair for scrolling backgrounds and leave non-tiling title artwork unchanged.
Verification
npm run test --workspace=packages/image-nodes -- game— 33 tests passed, including axis selection, center preservation, transparent pixels, tiny images, and 1920×1080 input.npm run test --workspace=packages/protocol -- game-graph— 39 tests passed.NODE_OPTIONS=--max-old-space-size=8192 npm run typecheck— passed in the development checkout.npm run lint— passed in the development checkout.VITEST_MAX_WORKERS=2 npm run dev:nodetool -- harness gate --base origin/main— 13/13 selfchecks passed in the development checkout.Checks ran against the combined development checkout before the focused PR commit was assembled. This PR contains only seam repair and its tests. Edge detail is intentionally softened when repair is enabled; ordinary SeamlessImage calls keep repair disabled by default.